refactor(analytics): replace useGetAnalytics with individual queries for decision outcomes, rule hits, and screening hits - #1203
Merged
Conversation
siiick
force-pushed
the
feat/in-app-analytics-split-queries
branch
from
November 7, 2025 12:01
74b449a to
4f48b31
Compare
…for decision outcomes, rule hits, and screening hits
siiick
force-pushed
the
feat/in-app-analytics-split-queries
branch
from
November 7, 2025 12:52
4f48b31 to
869dba1
Compare
Comment on lines
+212
to
+225
| const { data: decisionsOutcomesPerDayData, isFetching: isDecisionsOutcomesPerDayFetching } = | ||
| useGetDecisionsOutcomesPerDay({ | ||
| scenarioId, | ||
| queryString: queryString ?? '', | ||
| }); | ||
| const { data: ruleHitTableData, isFetching: isRuleHitTableFetching } = useGetRuleHitTable({ | ||
| scenarioId, | ||
| queryString: queryString ?? '', | ||
| }); | ||
| const { data: ruleVsDecisionOutcomeData, isFetching: isRuleVsDecisionOutcomeFetching } = useGetRuleVsDecisionOutcome({ | ||
| scenarioId, | ||
| queryString: queryString ?? '', | ||
| }); | ||
| const { data: screeningHitsTableData, isFetching: isScreeningHitsTableFetching } = useGetScreeningHitsTable({ |
Contributor
There was a problem hiding this comment.
The destructuring is not consistent with other uses of useQuery and also makes you alias field. It would be better to keep variables like decisionsOutcomesPerDayQuery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the parallel loading of analytics queries to the page level so that each chart and table is displayed as soon as its data becomes available.